-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dev-env): bypass Lando entrypoint for auxiliary images #2135
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- assets/dev-env.lando.template.yml.ejs: Language not supported
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
05ceb37
to
4772c18
Compare
I tested the happy path and it's happy, but I would like to test the unhappy path somehow |
55f3681
to
9db07e3
Compare
9db07e3
to
8b91294
Compare
Quality Gate passedIssues Measures |
Description
This PR updates the Landofile template to completely bypass the Lando entry point for auxiliary images that do not need custom scripts or permissions sweeps.
This:
Pull request checklist
New release checklist
Steps to Test
vip dev-env create -e -A -H -p < /dev/null vip dev-env start docker ps
ghcr.io/automattic/vip-container-images/nginx:latest
,elasticsearch:7.17.8
,phpmyadmin:5
,axllent/mailpit:latest
,memcached:1.6-alpine
, andmysql:8.4
containers must be running, and theirCOMMAND
must not mentionlando-entrypoint
;vip dev-env logs -S demo-app-code
must return nothing;vip dev-env logs -S devtools
must return nothing;vip dev-env logs -S wordpress
must return nothing;